maakbaas / esp8266-iot-framework

Framework for IoT projects implementing HTTPS requests, a React web interface, WiFi manager, live dashboard, configuration manager, file manager and OTA updates.
GNU General Public License v3.0
417 stars 113 forks source link

Update html build script subprocess.call #132

Closed bmanifold closed 2 years ago

bmanifold commented 2 years ago

First off, thank you for creating this framework, it's been a ton of fun to use.

I, and a few others working on a small project together, came across this bug while trying to create some custom fields in the configuration manager page. We were running in to a bug where the npm commands in the preBuildHTML.py script weren't getting run as intended.

We've been using PlatformIO to compile (on both Mac and Linux).
PlatformIO: Core-5.2.3

The versions of python we've been using: Mac - python:3.8.2
Linux - python:3.7.3

Below is a copy of the commit message to give more detail on the changes. Please let me know if any more information is needed/wanted and thank you for considering this PR.

Why:

This change addresses the need by:

maakbaas commented 2 years ago

Thanks for the detailed PR, I've merged it into the repository