Add timeout parameter for customising wifi connection timeout

maakbaas / esp8266-iot-framework

Framework for IoT projects implementing HTTPS requests, a React web interface, WiFi manager, live dashboard, configuration manager, file manager and OTA updates.

GNU General Public License v3.0

417 stars 113 forks source link

Add timeout parameter for customising wifi connection timeout #99

Closed jarrodbell closed 3 years ago

maakbaas commented 3 years ago

Thanks for the proposal. Before accepting, two small requests:

Could you add an overloaded function without the timeout to keep backwards compatibility?
Can you update the docs in docs/wifi-manager.md accordingly?

jarrodbell commented 3 years ago

Doesn't the default param value suffice? It already defaults to the same default as the WiFi package.

maakbaas commented 3 years ago

Doesn't the default param value suffice? It already defaults to the same default as the WiFi package.

Yes you are right, sorry I overlooked that :). Thanks!