search

maanyos / pe

0 stars 0 forks source link

unnecessary -address flag for filter #3

Open maanyos opened 2 years ago

maanyos commented 2 years ago

why have the -address flag for filter if the default already searches for -address? developer guide doesn't mention that there are future plans for different ways of filtering, and it seems like many parts of the user guide (like the feature list and command summary) leaves out the -address flag.

image.png

nus-se-bot commented 2 years ago

Team's Response

Hi, thank you for bug report!

The -address flag is left in to allow for flexibility when changing default behaviour. For example, if we would like to change the default behaviour for the filter command, we could make it so filter does filtering by ID, and filter -address for address filtering.

As such, we support both the optional dashed argument version as well as default behaviour, as defined in the UG:

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: your explanation sounds logical, please include it in your developer guide under design considerations or something
in that case, it's more of lack of documentation than feature flaw