Closed JesseDeLoore closed 2 years ago
Unfortunately, I don't have time this weekend to look at it.
I'll try to make time somewhere next week.
Also, my memory is like swiss cheese these days. So feel free to ping me if you feel I forgot.
As it is only a depreciation warning there is no high urgency. I'll try to remind you in some time:)
From: maarten-dp @.> Sent: Friday, March 11, 2022 11:57:10 AM To: maarten-dp/flask-restless-datamodel @.> Cc: Jesse De Loore @.>; Author @.> Subject: Re: [maarten-dp/flask-restless-datamodel] Warning for deprecation in flask 2.1 (Issue #6)
Unfortunately, I don't have time this weekend to look at it.
I'll try to make time somewhere next week.
Also, my memory is like cheese these days. So feel free to ping me if you feel I forgot.
— Reply to this email directly, view it on GitHubhttps://github.com/maarten-dp/flask-restless-datamodel/issues/6#issuecomment-1065002683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDDEWLAILIJBWXYRINMANTU7MRINANCNFSM5QPIYIRQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>
Beep beep boop boop. Reminder.
From: Jesse De Loore @.> Sent: Friday, March 11, 2022 12:00:15 PM To: maarten-dp/flask-restless-datamodel @.>; maarten-dp/flask-restless-datamodel @.> Cc: Author @.> Subject: Re: [maarten-dp/flask-restless-datamodel] Warning for deprecation in flask 2.1 (Issue #6)
As it is only a depreciation warning there is no high urgency. I'll try to remind you in some time:)
From: maarten-dp @.> Sent: Friday, March 11, 2022 11:57:10 AM To: maarten-dp/flask-restless-datamodel @.> Cc: Jesse De Loore @.>; Author @.> Subject: Re: [maarten-dp/flask-restless-datamodel] Warning for deprecation in flask 2.1 (Issue #6)
Unfortunately, I don't have time this weekend to look at it.
I'll try to make time somewhere next week.
Also, my memory is like cheese these days. So feel free to ping me if you feel I forgot.
— Reply to this email directly, view it on GitHubhttps://github.com/maarten-dp/flask-restless-datamodel/issues/6#issuecomment-1065002683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDDEWLAILIJBWXYRINMANTU7MRINANCNFSM5QPIYIRQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>
Was a bit more complex than originally thought. I'm also not 100% satisfied with the solution, as it's now making a couple of the same blueprint. I might do another round where I do a clean fix.
All tests pass on both the datamodel and the client using Flask 2.1, so it should be ok. Let me know if you experience side effects.
In short: datamodel: 0.2.10 (I messed up some releases :DDDD) client: 0.4.13 (If you want to get rid of the "server incompatible" warning)
The following warning is issued when the same blueprint is registered multiple times:
I'm not entirely sure why this is happening. I'd guess there are some blueprints shared between models and they are being added multiple times. Applying the following fix seems to work: