maartenbreddels / ipywebrtc

WebRTC for Jupyter notebook/lab
MIT License
241 stars 40 forks source link

JupyterLab 2.x #94

Closed alecapu80 closed 1 year ago

alecapu80 commented 3 years ago

When will be compatible with JupyterLab 2.x? Thank you!

maartenbreddels commented 3 years ago

Hi,

I think it's better to wait to 3.0, so we can make it pip installable without a build phase.

alecapu80 commented 3 years ago

Is compatible with 3.0 pre-lease?

alecapu80 commented 3 years ago

I've reverted to Version 1.2.18 but I've also an issue:

Failed validating settings (@jupyterlab/extensionmanager-extension:plugin): Additional properties are not allowed ('disclaimed' was unexpected)

Failed validating 'additionalProperties' in schema:
    {'additionalProperties': False,
     'description': 'Extension manager settings.',
     'jupyter.lab.setting-icon-class': 'jp-SettingsIcon',
     'jupyter.lab.setting-icon-label': 'Extension Manager',
     'properties': {'enabled': {'default': False,
                                'description': 'Enables extension manager '
                                               '(requires Node.js/npm).\n'
                                               'WARNING: installing '
                                               'untrusted extensions may '
                                               'be unsafe.',
                                'title': 'Enabled Status',
                                'type': 'boolean'}},
     'title': 'Extension Manager',
     'type': 'object'}

On instance:
    {'disclaimed': True}
nmstoker commented 3 years ago

@maartenbreddels is there any news on this, given that Jupyter Lab 3.0 was released in January? (this is definitely not meant as a nag, just an eager follow up as being able to use this in 3.0 would be great 🙂 )

maartenbreddels commented 3 years ago

I started working on it in https://github.com/maartenbreddels/ipywebrtc/pull/95 but it requires a change in jupyter lab

maartenbreddels commented 1 year ago

3.0 is supported.