maartenl / Land-of-Karchan

Where one can change into a hero with a single swipe of his sword.
http://www.karchan.org
GNU General Public License v3.0
7 stars 3 forks source link

Dark Mode Room Titles MASSIVE #91

Closed wastedshame closed 4 years ago

wastedshame commented 5 years ago

In dark mode, room titles and anything requiring h1, 2, or 3 tags are HUGE. I noticed it when I was programming something today and thought I would show you a comparison.

Same room. Center of Guilds.

image

Just thought you'd want to know. When I noticed, it surprised me.

maartenl commented 5 years ago

Aye, the normal mode uses bootstrap from https://getbootstrap.com. The darkmode uses a bootstrap theme called Cyborg from https://bootswatch.com.

The question, of course, is "is it a problem"?

nickicolem commented 5 years ago

Sorry this isnt related to dark mode room titles but is just a query re dark mode so thought i would ask here as not an issue. Out of curiosity is there a way when making a script for a command for the font to be either one colour if darkmode is off and then a different colour of dark mode is on? If so, any chance you could make simple dummy command showing this so we can look at it? If it is a hassle or not easily possible then no worries it was just out of curiosity is all as we have quite a few commands with colour fonts and what works for one mode does not work for the other always.

wastedshame commented 5 years ago

It's not a huge problem, but it does make certain rooms not aesthetically pleasing. I will post a screenshot when I find another room like it for visual reference.

maartenl commented 4 years ago

Darkmode: h1: 4rem

Normal mode: h1: 2.5 rem