Closed mkx173 closed 2 years ago
I simply copied the original implementation from simconnect and made some modifications. I know it is messy but I don't have time to rewrite it.
What part is copied and where is it from? just wondering that due to potential license compliance issues
Thanks for pointing out. Some code in aircraftstaterequest.py
is adapted from the original python-simconnect project. I've added a notice in the header. Also that project is under GPLv3 so you might want to change the license? If not I could probably do a rewrite in a few days.
I hope you can do a rewrite or something like that since I don't want to change the license of the project. Honestly not a big fan of GPL and all the limitations that come with it
Just finished the rewrite. Much easier than I thought. Maybe the original author just made it too complicated lol.
I'm currently not able to test the release. Can you give the pre-release a run and let me know if everything is working as usual? https://github.com/maartentamboer/X-Touch-Mini-FS2020/releases/tag/v1.10.0 After that I can make it an official release
Hello I just did some testing and both new and legacy matching works fine.
Great, I've officially released it now. Thanks for contributing 👍
I've added a new function that can match aircrafts by its base
aircraft.cfg
location. Theaircraft_contains
field inconfig.json
can now be a list. The keywords inaircraft_contains
is now case insensitive. Everything is fully compatible with previours configuration files.To use the new function, change the
aircraft_contains
to the base name of that aircraft (or a part of the base name) and add"use_aircraft_base_matching": true
to the global configuration.The base information for an aircraft can be found in the
aircraft.cfg
file under any livery folder for that aircraft. Or you can simply look at the output of the program. Something like this:If for some reason you don't want to use base matching, you can also add more keywords to
aircraft_contains
.Note: I added a
CustomSimconnect
class since the request system state function is not currently available in theSimconnect
package. It can be removed once it is added. I also added a workaround forSimconnect
0.4.24 since the field is not defined in 0.4.24. It is actually fixed in 0.4.25 but that version have a bug that prevents the program from running.