maartenvanvliet / moneybird

Ruby gem for the Moneybird REST API
https://github.com/maartenvanvliet/moneybird
MIT License
6 stars 21 forks source link

Webhooks can't be created #6

Closed tilsammans closed 6 years ago

tilsammans commented 6 years ago

I cannot create a new webhook via this gem. First, Moneybird::Traits::Save isn't included for Webhook. After I added that, the request is sent url-encoded, leading to a 400 error.

administration.webhooks.create url: "https://example.nl/moneybird/events"

@faraday_adapter=:net_http, @http=#<Faraday::Connection:0x0000000003cc0c38 @parallel_manager=nil, @headers={"User-Agent"=>"Faraday v0.12.2"}, @params={}, @options=#<Faraday::RequestOptions (empty)>, @ssl=#<Faraday::SSLOptions verify=true>, @default_parallel_manager=nil, @builder=#<Faraday::RackBuilder:0x0000000003cbe730 @handlers=[Faraday::Request::UrlEncoded, Faraday::Adapter::NetHttp], @app=#<Faraday::Request::UrlEncoded:0x0000000003adbc88 @app=#<Faraday::Adapter::NetHttp:0x0000000003ad90a0
maartenvanvliet commented 6 years ago

Thanks, I will look into it

tilsammans commented 6 years ago

I am more than happy to help maintain it also!

Op 2 nov. 2017 om 18:08 heeft Maarten van Vliet notifications@github.com het volgende geschreven:

Thanks, I will look into it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

maartenvanvliet commented 6 years ago

Fixed in 7d5c372f7cf4517f91647b55006315fe853ee7b3