Assignment-2-Replacement Review - Githubissues

maazmmd / bootcamp

Boot Camp (Oct 17-Jan 18)

0 stars 0 forks source link

Assignment-2-Replacement Review #1

Open sagarpatke opened 6 years ago

sagarpatke commented 6 years ago

Carousel in Homepage
- Third image resolution is different
Images for "Buy Or Service", "Car Cleaning" and "Accessories" appear stretched for medium or smaller width devices
Horizontal Scroll bar appears at the bottom of (every) page.
When I clicked on "Buy Supercar" page, I though the page was not loading. Later, I realized that the page has already loaded, and there is no content on it. Perhaps, gallery should be shown in a smaller grid.

Code Review:

Should use more semantic tags. For instance, "Buy or Service", "Car Cleaning and "Accessories" can have their own
tags;
tag could be used. "Contact Us" page, should have used
tag instead of
tags

Two areas where you have done well:

Image selection is impressive, and the website style feels consistent everywhere

Two areas where you can improve:

Use semantic HTML Tags
Learn to make images Responsive

maazmmd commented 6 years ago

Will try and use more Semantics and have a look on Issues