search

mabarnes / moment_kinetics

Other
2 stars 4 forks source link

Add bc that sets zero only at the incoming boundary #130

Closed johnomotani closed 8 months ago

johnomotani commented 10 months ago

...even when diffusion is present. This is in contrast to "zero" which sets zero at the incoming boundary when no diffusion is present, but zero at both boundaries when some diffusion is present. This may be useful when numerical diffusion is present but is small compared to the advection speed near the boundary. Specify with, e.g. vpa_bc = "incoming_zero".

Not sure whether this is really useful - I ended up not needing any numerical dissipation in my 1D1V runs for EFTC, so the existing "zero" bc was fine in the end. I guess we might as well add the option to force 'zero at the incoming boundary' in case it is useful in future.

johnomotani commented 8 months ago

Not sure this is really worth adding. It's easy to re-implement if it is needed in future.