In machine_setup.sh on macOS, prompt for MPI library path

mabarnes / moment_kinetics

Other

2 stars 4 forks source link

In machine_setup.sh on macOS, prompt for MPI library path #201

Closed johnomotani closed 5 months ago

johnomotani commented 5 months ago

MPIPreferences.use_system_binary() does not find the MPI library when it was installed with homebrew on macOS, so prompt for the user to give the path to the MPI library instead.

@LucasMontoya4 does this work for you?

@mabarnes did you need to work around this problem when using the machines/machine_setup.sh setup script?

Is there a default that we should check (for non-homebrew setups?) that could find the MPI library automatically? I don't have a Mac to test...

LucasMontoya4 commented 5 months ago

@johnomotani I’ll try that one out - although I’m not sure how common it is for Mac users to install MPI with homebrew, but I guess it’s still a general solution!

johnomotani commented 5 months ago

I've added the try-catch so if MPIPreferences.use_system_library() (with no extra arguments) runs without error, then we don't need to prompt for the MPI library path. So I think this is ready to merge now.