mabarnes / moment_kinetics

Other
2 stars 4 forks source link

MMS test bugfixes and docs #217

Closed mrhardman closed 2 months ago

mrhardman commented 4 months ago

PR to add

In addition, this could be a moment to discuss the best location to store the existing MMS input files - > should they be moved from runs to an examples_mms/ directory? @johnomotani

mrhardman commented 4 months ago

If I understand correctly, one consideration for the location of the MMS test TOML inputs could be that we might want to test whether the inputs are valid on CI, by running them for 1 timestep, like the TOML in examples/. Currently it looks like many of the MMS test inputs in the runs/ directory have become out of date following the various input namelist changes.

johnomotani commented 4 months ago

BTW all the documentation builds seem to be broken at the moment - there is some error about a missing get_cmap function when loading PyPlot. I don't think it's anything we've done, and I can't reproduce it on my laptop, so I'm hoping it goes away with some package updates (unless anyone wants to dig into it, e.g. excluding the version of PyPlot that it's currently trying to use so it falls back to the previous one?).