Closed jrb0001 closed 5 years ago
Please note that this breaks WindowsTerminal
if lanterna is used on the modulepath instead of the classpath. One way to solve that would be #422 and the alternative would be to move it to its own package and then use SPI to load it.
SPI sound like the better approach to me because that would also allow moving the terminal emulator part into its own module with proper runtime dependencies to java.desktop
.
I don't care too much about breaking the experimental, unfinished native bindings
The PR has two commits and I recommend reviewing them individually:
java.desktop
module. This allows producing smaller runtime images if you don't need the terminal emulator parts nor theTextColor.getColor()
method.I tested it on Java 11 with a modularized version of the
OutputString
example both with and without thejava.desktop
module.Is the package
com.googlecode.lanterna.bundle
meant to be used directly by the application/other libraries? If not, then itsexports
should be dropped.