search

mabe02 / lanterna

Java library for creating text-based GUIs
GNU Lesser General Public License v3.0
2.24k stars 243 forks source link

Fix #453 #454

Closed AObuchow closed 4 years ago

AObuchow commented 4 years ago

Signed-off-by: Andrew Obuchowicz andrewobuchowicz@gmail.com

AObuchow commented 4 years ago

For some reason, I was able to compile the source with mvn verify but had classpath compile errors in Eclipse. I think it might be due to Java 9 source files being referenced on the classpath, but I have Java 11 installed? Not quite sure.

Hopefully, this should work as a fix though.

jrb0001 commented 4 years ago

The java9-Sources override the classes for Java 9 or later. It basically picks the latest variant of a class <= the JRE version, although the mechanism only exists since Java 9.

AObuchow commented 4 years ago

The java9-Sources override the classes for Java 9 or later. It basically picks the latest variant of a class <= the JRE version, although the mechanism only exists since Java 9.

I see, thanks for the info :) Does that mean I should change my JRE to a lower variant (eg Java 9)? I currently only have Java 8 and 11 installed, maybe I should install Java 9? If you're not certain, I'll just install Java 9 and look into it further myself.

jrb0001 commented 4 years ago

No need to do that. Java 8 will use the normal class and Java 11 will use the Java 9 variant (because there is no newer variant).

AObuchow commented 4 years ago

No need to do that. Java 8 will use the normal class and Java 11 will use the Java 9 variant (because there is no newer variant).

I see, so odds are I need to use Java 8 or download Java 9, so that Java 11 will have access to the Java 9 variant.

jrb0001 commented 4 years ago

I meant the variant of the class, not the variant of the JRE/JDK.

AObuchow commented 4 years ago

@jrb0001 ahh okay, thanks for the clarification :)

mabe02 commented 4 years ago

Thanks @jrb0001 and @avl42 for reviewing. I think you caught everything.

AObuchow commented 4 years ago

Thanks for merging this @mabe02! PS: I'm having a blast using this library, it's really awesome :)