wrong javadoc or wrong visibility of a method ?

mabe02 / lanterna

Java library for creating text-based GUIs

GNU Lesser General Public License v3.0

2.3k stars 243 forks source link

wrong javadoc or wrong visibility of a method ? #592

Closed avl42 closed 10 months ago

avl42 commented 10 months ago

https://github.com/mabe02/lanterna/blob/54f5b4ca6b33eaa41cc666f5d7bce8f08ddc132a/src/main/java/com/googlecode/lanterna/terminal/ansi/UnixTerminal.java#L29

Here it suggests to override getSTTYCommand(), but that method is private in UnixLikeTTYTerminal. Either it should suggest overriding runSTTYCommand(), or getSTTYCommand() should be made "protected". I'd prefer the latter of the two.

mabe02 commented 10 months ago

Yeah, it's outdated after some of the refactorings. Will see if I can remember what the appropriate way to do this now is.

mabe02 commented 10 months ago

Made it protected, seems most straight-forward

mabe02 commented 10 months ago

Commit here: https://github.com/mabe02/lanterna/commit/2f4e3b7f37d8645ef001c0dcc05d7ef2ad749044

For some reason Github didn't auto-detect it