search

mabl / PyPylon

An experimental python wrapper around the Basler Pylon 5 library
BSD 3-Clause "New" or "Revised" License
53 stars 34 forks source link

feature request: add grab strategies #20

Open ZacDiggum opened 8 years ago

ZacDiggum commented 8 years ago

Would it be possible to add the supported grab strategies to grab_images()? I noticed a corresponding annotation in factory.pyx.

mabl commented 8 years ago

Sure, it's just that I'm driven by my PhD and little short on time... I hope to take a look at it too. I personally like the iterator approach. However, one does not "know" when an iterator is not needed anymore in Python. So I might drop the iterator style API and expose something closer to the metal..

ZacDiggum commented 8 years ago

Oh, of course. Sorry for my impatience. I'll try to add the strategies myself. By now, the integration of the Basler camera into my existing application works quite well, thanks to PyPylon. There's only a little thread safety thing left but that's about PyQt. When I got this done I could make a small PyQt example GUI as a showcase for PyPylon. Anyways, I wish you success with your PhD. :thumbsup:

ZacDiggum commented 8 years ago

Unfortunately I'm not able to add the grab strategies myself. @RichardLangFromNZ, would you be willing to do this?

RichardLangFromNZ commented 8 years ago

Looks like we need this for the work we're trying to do, so will probably be able to put some time into it and push something back fairly shortly

RichardLangFromNZ commented 8 years ago

Fix in PR https://github.com/mabl/PyPylon/pull/23

ZacDiggum commented 8 years ago

@RichardLangFromNZ Thanks! Cool! Thanks again! :+1: