APT devices must return serial number to pick the right one

mabuchilab / Instrumental

Python-based instrumentation library from the Mabuchi Lab.

http://instrumental-lib.readthedocs.org/

GNU General Public License v3.0

120 stars 80 forks source link

APT devices must return serial number to pick the right one #131

Open FilipDominec opened 3 years ago

FilipDominec commented 3 years ago

As originally referenced in https://github.com/mabuchilab/Instrumental/issues/130, I suggest the ParamSet for Thorlabs motion controllers TDC001 should contain their serial number to tell these apart.

Also I noticed my controllers do not report correctly the 5th and 6th byte, causing some commands to stall.

With these two fixes, TDC001s work like charm.

FilipDominec commented 3 years ago

OK, thanks. Meanwhile I got my repository into unusable state again and have no expert to help, so tomorrow I will clone the repository anew and submit another PR based on your notes. Programming is easy, git is hard.