Open fthdgn opened 6 months ago
Awesome !
@mac-cain13 👍
waiting for it ^^
Let's merge it
When are we gonna see that PR in action?
I am keen to use this on a new app that im starting to work on :)... Lets merge!
I think R.swift will die. I already moved on and removed it on my project. What I did:
@aiKrice
Came here because of the feeling that Swiftgen is not really updated any more and seems to die.
The inconsistency build errors all disappeared after running
`defaults write com.apple.dt.XCBuild BuildDescriptionInMemoryCacheSize 0`
source: https://mastodon.social/@NeoNacho/112560574952551066
Pod library version 7.6.0 has not merged the above pull request. Please work on it. Thank you!
Updated version of #865. I couldn't update source branch of previous PR bacause it has references on my own apps.
Difference from #865
I did a simple development for xcstrings support.
It is backward compatible for for
.xcstrings
files converted from.strings
files. It means the same R.string codes will be generated.However, it is not backward compatible for
.xcstrings
files converted from.stringsdict
files, because of named arguments.About named arguments
My implementation strips names of substitutions from generated arguments. I found using them problematic on some cases.
In my opinion, named arguments does not worth the implementation. Xcode generates substituons only if there are more than one pluralable parameter on new xcstrings files. The most of the string values will not be have any information to generate named arguments.
Problematic case 1
Some key information is lost on the xcstring convertion of stringsdict files. Original stringsdict content.
Generated xcstrings content
R.swift creates .x_users(users: Int) for stringsdict file. However, xcstrings file does not have the argument name information any more.
If string value of the original content is
<string>Add %#@users@</string>
, generated xcstrings would keep the substitution information.Problematic case 2
This strings value is "1 iPhone and 10 touches" on iPhones and "1 Mac and 10 keys" on Mac. There are 2 substitutions for each device variation. Which signature should we use? .example(device_iphone: Int, input_iphone: Int) .example(device_mac: Int, inputmac: Int) .example( arg1: Int, _ arg2: Int) .example(device Int, input: Int) //With some extra coding to detect shared parts of the names.
About algorithm
The alghorithm tries to convert localization of source language to single string with basic format parameters, then it uses FormatPart.formatParts(formatString:)` on this string to extract parameters.
This convertion works like that:
Substitutions replacement works like that:
Example 1
Example 2
Example 3
%#@books@ and %#@pens@
%arg book
%1$lld book
%1$lld book and %#@pens@
%arg pen
%2$lld pen
%1$lld book and%2$lld pen
%1$lld book and %2$lld pen
. [%lld, %lld]