search

mac-cain13 / xdebug-helper-for-chrome

Easily activate PHP debugging, profiling and tracing with this Xdebug Chrome extension
https://chrome.google.com/webstore/detail/eadndfjplgieldjbigjakmdgkmoaaaoc
307 stars 97 forks source link

switch `chrome.runtime` for `chrome.extension` #36

Closed kived closed 10 years ago

kived commented 10 years ago

So, after a little more research, I found there was an API change breaking tons of extensions. The chrome.extension API has been deprecated and removed in favor of the chrome.runtime API. Swapped those and it seems to be working now.

There are a few minor issues still:

When loading the extension, the following message is displayed: There were warnings when trying to install this extension: Unrecognized manifest key 'short_name'.

The menu is not very responsive - when a menu item is clicked, the item does not turn green. If you close and reopen the menu though it will highlight the appropriate item.

Closes #35

mac-cain13 commented 10 years ago

Thanks for the PR! I'll check it out/merge it this weekend.

mac-cain13 commented 10 years ago

Thanks for taking the time to create a PR! I've (finally) got some time to check it out and I've some questions.

You state that chrome.extension is deprecated/removed from the API, but I can't find any documentation from Google on that. The "What's new" page doesn't mention a deprecation and/or removal. But then the page stops at Chrome 26 while Chrome 30 is now stable, so it could that the page is outdated.

I do see that chrome.runtime is newer (Stable since Chrome 22) and is the way to go in the future, but it doesn't explain why this is broken + changing. So I'm curious if you have any (Google) source stating this change.

Anyway, I'm now merging this so we're future proof! Thanks again for your time.