mac-cain13 / xdebug-helper-for-chrome

Easily activate PHP debugging, profiling and tracing with this Xdebug Chrome extension
https://chrome.google.com/webstore/detail/eadndfjplgieldjbigjakmdgkmoaaaoc
307 stars 97 forks source link

Configuring custom profiler trigger value seems to only return XDEBUG_ECLIPSE as the value #69

Closed mmccollum closed 7 years ago

mmccollum commented 8 years ago

I have the following configuration in php.ini: xdebug.profiler_enable_trigger=1 xdebug.profiler_enable_trigger_value="XDEBUG_PROFILE" xdebug.profiler_output_dir=/www/xdebug

When I try to configure the plugin to set XDEBUG_PROFILE as the value of the XDEBUG_PROFILE cookie, it generates the cookie with XDEBUG_ECLIPSE.

This is also true if I enter another string into the value, such as 'TEST'

When I comment out the profiler_enable_trigger_value, xdebug does trigger the profiler.

neochief commented 8 years ago

For me it looks as if trigger values in plugin are hardcoded to XDEBUG_ECLIPSE. I can't change them, nothing is being saved and the cookie is set to XDEBUG_ECLIPSE for both trace and profiler.

neochief commented 8 years ago

Okay, the issue is fixed in this PR: https://github.com/mac-cain13/xdebug-helper-for-chrome/pull/70

tdtm commented 8 years ago

The issue seems to remain in the Chrome store version (and its last update was on March 28, 2016, so that would make sense).

I'll load the dev version on my end, but it'd be great to have the person with appropriate Store access to do it up there as well. /cc @mac-cain13

mac-cain13 commented 8 years ago

Thanks for the reminder. This did fall off my radar, I'm sorry. I'll merge #70 and release a new version as soon as I have some time!

tdtm commented 8 years ago

No worries, it happens! #66 seems good to go as well.

mac-cain13 commented 7 years ago

This is (finally) merged!

eselskas commented 4 years ago

This is still happening :(