mac-s-g / react-json-view

JSON viewer for react
https://mac-s-g.github.io/react-json-view/demo/dist/
MIT License
3.45k stars 494 forks source link

Returning false in onDelete changes .updated_src in v1.21.3 #393

Open busterbogheart opened 2 years ago

busterbogheart commented 2 years ago

Despite the documentation, returning false does alter the internal state of the module and changes updated_src. I've set up a simple demo here: https://codesandbox.io/s/naughty-ganguly-l2zr38?file=/src/App.js

This causes, at least: when being blocked from deleting a key, and then successfully removing a different one, both rows disappear.

esankin commented 2 years ago

Same happens with onEdit

lyleaigbedion commented 2 years ago

Running into the same issue.

berkanaslan commented 4 months ago

Same issue.