search

mac-theobio / McMasterPandemic

SEIR+ model
GNU General Public License v3.0
20 stars 5 forks source link

Harmonize time varying multipliers on the start date with lin_params #133

Closed stevencarlislewalker closed 2 years ago

stevencarlislewalker commented 2 years ago

When 'do_make_state == TRUE', there are two ways to supply parameter values for the linearized model that is used to compute the initial state: one using 'update_lin_params' and one on the start date in 'params_timevar'. The user needs to be warned if they specify both, and the 'params_timevar' takes precedence.

  1. Create a small reproducible example that illustrates failures due to this bug/missing feature
  2. Check for a time varying parameter on the start date
  3. If one exists, add an item in the data structure to TMB that allows for updates of sp immediately after it is created while still preserving the sp_orig so that rel_orig still works later in the simulation loop
  4. If do_make_state is on then also add an item to linearized_params so that the correct parameters are used in state construction as well
stevencarlislewalker commented 2 years ago

Not an issue. Initially I wondered (unnecessarily in hindsight) if we needed to treat time variation on start_date specially, but it turns out that this is not required to match the R engine. If this issue really was a bug, it might have meant that we do not need this feature: #136.