mac-theobio / McMasterPandemic

SEIR+ model
GNU General Public License v3.0
20 stars 5 forks source link

Change add/update functions to have a consistent naming scheme and behaviour #227

Open stevencarlislewalker opened 2 years ago

stevencarlislewalker commented 2 years ago

Proposal:

Perhaps append_* should just be kept as add_* to minimize changes?

Perhaps there is no difference between create_* and replace_* and the latter is better?

Every model component should have all applicable verbs defined.

stevencarlislewalker commented 2 years ago

FYI @papsti , @wzmli , @Flynn-Primrose , @evanjmitchell. Comments would be welcomed.

evanjmitchell commented 2 years ago

I think that all sounds good. For me personally the only point of confusion was add vs. update, but changing update to edit fixes that I think. I agree that you could just keep add to minimize changes (instead of changing it to append).