Open stevencarlislewalker opened 2 years ago
FYI @papsti , @wzmli , @Flynn-Primrose , @evanjmitchell. Comments would be welcomed.
I think that all sounds good. For me personally the only point of confusion was add
vs. update
, but changing update
to edit
fixes that I think. I agree that you could just keep add
to minimize changes (instead of changing it to append
).
Proposal:
create_*
when adding a component to a model that doesn't yet have that componentreplace_*
when overwriting an existing componentappend_*
for 'list components' (e.g.add_rate
should beappend_rate
,vec_rate
should beappend_vec_rate
)remove_*
for removing items from 'list components'edit_*
for modifying values of existinglist/vector components
(e.g.edit_params(beta = 0.2)
instead ofupdate_params(beta = 0.2)
) -- not sure if there should be anedit_rate
for modifying the formula for a particular ratereset_*
for returning a model component to the default (typically this is a NULLish object like a zero-row data frame or a zero-length list)Perhaps
append_*
should just be kept asadd_*
to minimize changes?Perhaps there is no difference between
create_*
andreplace_*
and the latter is better?Every model component should have all applicable verbs defined.