mac-theobio / McMasterPandemic

SEIR+ model
GNU General Public License v3.0
20 stars 5 forks source link

Various problems with examples introduced by ip_devel merge #58

Closed matthewcso closed 3 years ago

matthewcso commented 3 years ago

Currently done: Added make_betavec back, fixed problems with compiling vignettes

Additional R CMD Check Warnings Warning messages: 1: In tools::parse_Rd(path, macros = macros) : C:/Users/somat/Documents/GitHub/McMasterPandemic/man/expand_params_variant.Rd:22: unknown macro '\item' 2: In tools::parse_Rd(path, macros = macros) : C:/Users/somat/Documents/GitHub/McMasterPandemic/man/expand_params_variant.Rd:24: unknown macro '\item' 3: In tools::parse_Rd(path, macros = macros) : C:/Users/somat/Documents/GitHub/McMasterPandemic/man/expand_params_variant.Rd:26: unexpected section header '\description' 4: In tools::parse_Rd(path, macros = macros) : C:/Users/somat/Documents/GitHub/McMasterPandemic/man/expand_params_variant.Rd:29: unexpected section header '\examples' 5: In tools::parse_Rd(path, macros = macros) : C:/Users/somat/Documents/GitHub/McMasterPandemic/man/expand_params_variant.Rd:33: unexpected END_OF_INPUT '

bbolker commented 3 years ago

The unknown macro/unexpected END_OF_INPUT stuff was caused by an unescaped % in the documentation, that's fixed now.

bbolker commented 3 years ago

vis_model and make_ratemat stuff should be fixed now.

bbolker commented 3 years ago

rExp example is fixed (sort of, although rExp should probably still be examined: see also #51 ). There is still an error withtests/test_calibrate.R (not tested via devtools::test()) and a bunch of undocumented arguments and undefined symbols (unimported or used via non-standard evaluations)

bbolker commented 3 years ago

@matthewcso , I guess you're working on this; let me know if I can help

matthewcso commented 3 years ago

@bbolker You solved all the bullet points in this issue (examples breaking), so I'll close this and open a new issue for the other rcmdcheck issues.