search

macabeus / react-gbajs

🕹 GBA emulator on your React project - easy and powerful to use!
https://www.npmjs.com/package/react-gbajs
BSD 2-Clause "Simplified" License
71 stars 14 forks source link

Wrong type for GBAProvider #22

Closed VladCuciureanu closed 1 year ago

VladCuciureanu commented 1 year ago

Trying to wrap a JSX node inside GBAProvider results in the following error: Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes'.

This is due to GBAProvider being typed as FunctionComponent instead of FunctionComponent<{children:ReactNode}> or similar types.

macabeus commented 1 year ago

Hello. Thanks for the report. I'm now busy with other personal projects, so I'm unsure when I'll fix it.

If you can open a PR fixing it, I would be glad and faster to release a new version fixing it