search

macadmins / SplashBuddy

Onboarding splash screen for MDM and Automated Device Enrollment.
Apache License 2.0
403 stars 70 forks source link

SB beach balls when click Continue #112

Closed davidyoondrums closed 5 years ago

davidyoondrums commented 5 years ago

I am using

continueAction /Applications/Self Service.app applicationsArray to launch Jamf Self Service upon clicking continue button. But occasionally SB beach balls, and the only thing I can do is to force restart the computer. It doesn't happen all the time. I can see Self Service launching in the translucent SB background so I know Self Service app is launching in the background but SB seems to hang hard while trying to terminate itself after launching the app.
cybertunnel commented 5 years ago

Did your commit resolve the issue you were having @davidyoondrums?

davidyoondrums commented 5 years ago

Did your commit resolve the issue you were having @davidyoondrums?

I haven't extensively tested it but it seems to have resolved the issue.

cybertunnel commented 5 years ago

Did your commit resolve the issue you were having @davidyoondrums?

I haven't extensively tested it but it seems to have resolved the issue.

Thanks for the response, have you been able to test further? I have not been able to replicate the issue on my end, so wanted to ensure this fixes the described issue before pulling into the development branch.

davidyoondrums commented 5 years ago

I tested it and other have tested it also. I think are good to go!

damien-rivet commented 5 years ago

Thanks @davidyoondrums for the feedback. I'll merge the PR to integrate your fix unto the next release.

damien-rivet commented 5 years ago

Fixed by #113.