Closed canalnoises closed 3 years ago
@ygini can you tell me why my pull request was closed without merging it into master? I've been using this fix in my environment for over a year and it works great. It solves a problem that others were experiencing (see issue #73) so I thought this would be a shoe-in. Just curious 🤷🏼♂️
Hello
The PR got closed automatically because of the branch deletion. Sorry for that.
Your change request however is completely legitimate.
Can you re-do your PR from a fork of the last main
branch? We did a lot of code changes in SplashBuddy recently, on multiple different forks and with maintainer move. This caused a lot of trouble to reintegrate all changes. Sorry for that.
Oh, no worries. I'll redo it. Thanks!
Fix for Issue #73 where SplashBuddy incorrectly assumes that users that have their home directory in /Users.