macadmins / installapplications

A tool for dynamically using installapplication

Apache License 2.0

285 stars 62 forks source link

Update for M1 #100

Open andrewzirkel opened 2 years ago

andrewzirkel commented 2 years ago

These are the changes I had to make to run on M1. Feel free to take or leave any of them.

In build_python_framework use 10.9 build of python to have an all intel build. Pyobjc did not have an M1 build that I could see.
In generatejson.py another argument was added in an earlier commit.
In py3_requirements.txt build all binaries, otherwise I got missing dependencies and a broken python.

bfreezy commented 2 years ago

My 2c on the python pieces:

I'm not sure that dropping the build from 11 to 10.9 is the right call. Munki doesn't do this and it supports both Intel and Arm.
For pyobjc (and everything else), we should probably just add --no-binary :all: at the end of the py3_requirements.txt file and compile everything. Many wheels are x86_64 only at the moment.

andrewzirkel commented 2 years ago

I agree and did test that but get an error message when running build_python_framework errors at Running setup.py install for pyobjc-framework-AutomaticAssessmentConfiguration with: `file not found

import <AutomaticAssessmentConfiguration/AutomaticAssessmentConfiguration.h>`

I haven't looked into it more than that yet.

erikng commented 2 years ago

I probably should merge the changes I made on macadmins/python to the build script to make it work universally. But yes, 11.0 is not necessary at all.