Cleanup removes embedded Python before reboot command is issued

[lucasjhall]

context

• IA is running a bash root script in userland
• Using master and embedded python
• reboot command is issued and present in IA log w/o errors
• [InstallApplications] Triggering reboot

workaround

• issuing the same command via bash in the subprocess call works as expected
• /sbin/shutdown -r now
• have IA check for a installed item/sha and then exit 0 after restart
• not ideal, hence workaround

further investigation

• moved installapplications to Library
• ran test.py to simply test the python reboot call

#!/Library/installapplications/Python.framework/Versions/3.8/bin/python3
...
subprocess.call(['/sbin/shutdown', '-r', 'now'])
...

• that worked as expected

hypothesis

• cleanup(0) being triggered prior to a reboot breaks embedded python

    cleanup(0)

    if reboot:
        iaslog('Triggering reboot')
        subprocess.call(['/sbin/shutdown', '-r', 'now'])

• so calling the embedded python at /Library/installapplications/Python.framework/Versions/3.8/bin/python3 would fail
• it doesn't exist, since we just cleaned it up
• but this script is still in memory so it works?

[lucasjhall]

@erikng

I pulled fixrebootpy3 and deployed.

The process ended in a reboot as expected.

[erikng]

Did everything cleanup?

Was the last log event after the reboot a cleanup entry?

[lucasjhall]

Yes, verified:

• /Library/installpllications was removed
• LaunchAgent and LaunchDaemon were removed.

Logs appeared as expected:

...
Python[107:1419] [InstallApplications] Starting root script: /Library/installapplications/script.sh
Python[107:1419] [InstallApplications] Running Script: /Library/installapplications/script.sh
Python[107:1419] [InstallApplications] Attempting to remove LaunchDaemon: /Library/LaunchDaemons/com.erikng.installapplications.plist
Python[107:1419] [InstallApplications] Attempting to remove LaunchAgent: /Library/LaunchAgents/com.erikng.installapplications.plist
Python[107:1419] [InstallApplications] Targeting user id for LaunchAgent removal: 0
Python[107:1419] [InstallApplications] Attempting to remove LaunchAgent: com.erikng.installapplications
Python[107:1419] [InstallApplications] Attempting to remove InstallApplications directory: /Library/installapplications
Python[107:1419] [InstallApplications] Attempting to remove LaunchDaemon: com.erikng.installapplications
Python[107:1419] [InstallApplications] Cleanup done. Exiting.

[erikng]

Hm, could have sworn on the branch there should have been a reboot log event prior to the last message.

[erikng]

Addressed with https://github.com/erikng/installapplications/pull/59