Closed lucasjhall closed 4 years ago
Did everything cleanup?
Was the last log event after the reboot a cleanup entry?
Yes, verified:
/Library/installpllications
was removedLogs appeared as expected:
...
Python[107:1419] [InstallApplications] Starting root script: /Library/installapplications/script.sh
Python[107:1419] [InstallApplications] Running Script: /Library/installapplications/script.sh
Python[107:1419] [InstallApplications] Attempting to remove LaunchDaemon: /Library/LaunchDaemons/com.erikng.installapplications.plist
Python[107:1419] [InstallApplications] Attempting to remove LaunchAgent: /Library/LaunchAgents/com.erikng.installapplications.plist
Python[107:1419] [InstallApplications] Targeting user id for LaunchAgent removal: 0
Python[107:1419] [InstallApplications] Attempting to remove LaunchAgent: com.erikng.installapplications
Python[107:1419] [InstallApplications] Attempting to remove InstallApplications directory: /Library/installapplications
Python[107:1419] [InstallApplications] Attempting to remove LaunchDaemon: com.erikng.installapplications
Python[107:1419] [InstallApplications] Cleanup done. Exiting.
Hm, could have sworn on the branch there should have been a reboot log event prior to the last message.
Addressed with https://github.com/erikng/installapplications/pull/59
context
master
and embedded python[InstallApplications] Triggering reboot
workaround
/sbin/shutdown -r now
exit 0
after restartfurther investigation
installapplications
toLibrary
hypothesis
cleanup(0)
being triggered prior to a reboot breaks embedded python/Library/installapplications/Python.framework/Versions/3.8/bin/python3
would fail