search

macadmins / installapplications

A tool for dynamically using installapplication
Apache License 2.0
285 stars 62 forks source link

item var not defined with follow_redirects set #87

Closed eightnoneone closed 3 years ago

eightnoneone commented 3 years ago

I'm no python dev, but should this line be?

json_data.update({'follow_redirects': True}) instead of item.update({'follow_redirects': True})

I'm getting this error running 2.0.2

Screen Shot 2021-01-17 at 9 33 00 PM
erikng commented 3 years ago

No. @bfreezy any ideas on this one?

erikng commented 3 years ago

Actually yes this might have been a bug in the initial PR by the author. Try it out and report back.

eightnoneone commented 3 years ago

Well, I didn't really need redirects, so I turned that off. I'll see if I can go back and test it.

bfreezy commented 3 years ago

Yep, my mistake. Thanks for catching @eightnoneone

I got a PR up to fix and will test later this week when I return to work.

erikng commented 3 years ago

I'm going to close this since no one has brought it up for a few months.