Closed thehilll closed 3 years ago
sorry for just seeing this. I just merged something that conflicts here. Can you take a look?
Sorry this took so long, I was away.
I've updated generatejson.py
to be based off your new version. I've looked, but I can't figure out the proper way to update my fork's branch so that this doesn't show conflicts. If you like I could just close this and create a new pull request pulled from your current version.
Thanks.
Yeah let's do that.
Ok, I've done that and will close this one. Thanks again.
This moves the main loop that processes all of the
--item
arguments and creates thestages
dictionary out into a separate function.The point of this is to allow accessing this code from a process outside of
generatejson.py
that might be more complex. We have an external process that uploads all of the files (andbootstrap.json
) to a host as well as generates signed URLs. In the past we have calledgeneratejson.py
viasubprocess
, but that seems like a bit of a hack.Rather than re-implement all of the code you use to generate the important dictionary and file hashes in our script, it seemed like we might suggest this modification that would allow external tools to get access to the dictionary that
generatejson.py
constructs easily.Changes are:
Thanks for considering this.