search

macadmins / jamf-pro-sdk-python

A client library for the Jamf Pro APIs and webhooks.
https://macadmins.github.io/jamf-pro-sdk-python/
MIT License
44 stars 10 forks source link

[Bug] Bizarre 409 error when updating a static group using a string value for the computer ID. #29

Open brysontyrrell opened 8 months ago

brysontyrrell commented 8 months ago

Steps to Reproduce

client.classic_api.update_static_computer_group_membership_by_id(1, computers_to_add=["1"])

Expected Result

The computer is added. The underlying code should be casting the string value to an integer. The Pydantic model exports the correct XML document if the provided value is a string or an integer.

Actual Result

Debug logging to the console:

[ERROR] HTTPError: 409 Client Error:  for url: https//XXXXXXXXXX/JSSResource/computergroups/id/1
Error: Unable to match computer

I think this is an encoding issue with the XML and Jamf is throwing an incorrect error.

When looking up a computer using the Pro API that returns the id as a string value. Passing this directly to the static group update call surfaced the error.

System Information

jamf-pro-sdk 0.3a1 Jamf Pro 10.48.2