search

macadmins / nudge-python

A tool to help users with pre-existing devices upgrade their OS version.
Apache License 2.0
212 stars 45 forks source link

Fix for `days_between_notifications` #32

Closed aysiu closed 4 years ago

aysiu commented 4 years ago

This fixes it so that if days_between_notifications is set, it's also respected.

Two pieces to this are:

  1. Using the right comparison variable (os_version instead of os_version_major)
  2. Updating the last_seen pref every time the notification window actually appears
aysiu commented 4 years ago

As I'm doing further testing, I'm not sure that second commit makes sense. I swear I have a 10.15 machine on which it spits back 10 instead of 10.15, but I'm looking on another machine now where it spits back 10.15 for os_version_major.

Disregard this PR for now. I clearly need to do even more testing...

erikng commented 4 years ago

Heh. Welcome to my life.