macadmins / nudge

A tool for encouraging the installation of macOS security updates.
Apache License 2.0
1.03k stars 187 forks source link

Optimization of Japanese text #637

Closed enpipi closed 1 month ago

enpipi commented 1 month ago

I am Japanese. I feel uncomfortable with the Japanese translation. I will propose a Japanese sentence. It may be possible to make it the target of updateElements.

If I can get a list of the target characters, I will translate them all. I will also ask other people I know to help.

erikng commented 1 month ago

https://github.com/macadmins/nudge/blob/e9a042b864a0435858b7971d0b7c90ee46375ca2/Localizable.xcstrings

All of the text is here. Each value has its corresponding "ja" key but honestly it's much simpler to do this within Xcode than the file directly.

enpipi commented 1 month ago

Thank you. I'm creating a pull request.

erikng commented 1 month ago

Saw you committed something in your own repo but no PR.

erikng commented 1 month ago

I added your changes here

https://github.com/macadmins/nudge/commit/647f81a4b5851039bb7ea42e19b34ed36a41f3cb

enpipi commented 1 month ago

@erikng I apologize for any inconvenience caused by my English studies. I made some corrections to the translation. thanks