macadmins / nudge

A tool for encouraging the installation of macOS security updates.
Apache License 2.0
1.05k stars 187 forks source link

"aboutUpdateURL" should be a localizable string #93

Closed shoopdawoop closed 3 years ago

shoopdawoop commented 3 years ago

in com.github.macadmins.Nudge.json so users might get sent right to the localized version of the help site.

Btw. thank you for open sourcing this :)

erikng commented 3 years ago

This is a great idea. I'll have to think about how to add this functionality is as it would make the osVersionRequirement key more complex than I intended it to be.

erikng commented 3 years ago

You can now do something like

{
    "osVersionRequirements": [
        {
            "aboutUpdateURLs": [
                {
                    "_language": "en",
                    "aboutUpdateURL": "https://support.apple.com/en-us/HT211896#macos1121"
                },
                {
                    "_language": "es",
                    "aboutUpdateURL": "https://support.apple.com/es-es/HT211896"
                },
                {
                    "_language": "fr",
                    "aboutUpdateURL": "https://support.apple.com/fr-fr/HT211896"
                }
            ],
            "majorUpgradeAppPath": "/Applications/Install macOS Big Sur.app",
            "requiredInstallationDate": "2021-02-28T00:00:00Z",
            "requiredMinimumOSVersion": "11.2.1",
            "targetedOSVersions": [
                "11.0",
                "11.0.1",
                "11.1",
                "11.2"
            ]
        }
    ]
}

Thanks again for the report. Nudge v0.0.2.02152021143543 and higher will support this functionality.

shoopdawoop commented 3 years ago

Wow, that was quick. Awesome, I'll give it a try later.