search

macalimlim / godot-rust-template

A template for godot-rust projects
MIT License
51 stars 22 forks source link

can't `make run` on my x86_64 macbook #48

Open EverlastingBugstopper opened 2 years ago

EverlastingBugstopper commented 2 years ago

here's the output i get:

$ make run
Makefile:2: *** missing separator.  Stop.

to show my environment:

clang -v
Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

thanks for providing this project!

Heiss commented 2 years ago

Hey,

i am an explorer of this template, too. So i do not know much about it already. But i found this wiki, which should handle your issue.

Hope it helps. Install cargo install cargo-make to work with.

macalimlim commented 2 years ago

@EverlastingBugstopper I will be deprecating the old Makefile (using make) in favor of Makefile.toml (using cargo-make). It handles stuff on different platforms much better than running make. Going forward, please use cargo-make.

EverlastingBugstopper commented 2 years ago

Will do!

macalimlim commented 1 year ago

Hi @EverlastingBugstopper

Are you still facing some issues? Have you tried cargo make run? If everything is working on your side, we can close this issue.

Mike

EverlastingBugstopper commented 1 year ago

Hi @macalimlim thanks for the bump on this - always nice to close out old issues!

I just checked out commit 596efeba9c14b6ee64a43a380c95f1f824a91fbb (HEAD of main at the time of this comment) and tested a few things, unfortunately running into an error with Makefile.toml.

Here's my shell session:

$ uname -ms
Darwin x86_64
$ cargo --version    
cargo 1.65.0 (4bc8f24d3 2022-10-20)
$ cargo make --version
cargo-make 0.36.3
$ cargo make run
[cargo-make] INFO - cargo make 0.36.3
[cargo-make] ERROR - Unable to parse external file: "./Makefile.toml", expected a table key, found a left brace at line 1 column 1
[cargo-make] WARN - Build Failed.

Let me know if there's anything else I can do to help!

EverlastingBugstopper commented 1 year ago

Ah this happened because I needed to cargo generate the directory. I wonder if maybe there's another layer of indirection y'all could add here where you have cargo make run fall back to running Makefile.git.toml if parsing Makefile.toml has those template strings in there. Or just like - if Makefile.toml has template strings in it, remove them first. 🤷🏼 Or you could just say hey that's user error and you have to cargo generate it.

Regardless, after running cargo generate I still get an error:

$ cargo make run
[cargo-make][1] INFO - Running Task: run-godot-macos
/var/folders/84/27d0pzc96ksgv48z4g5dm8jh0000gn/T/fsio_g9lJKKnE5O.sh: line 4: /Applications/Godot.app/Contents/MacOS/Godot: No such file or directory
[cargo-make][1] ERROR - Error while executing command, exit code: 1
[cargo-make][1] WARN - Build Failed.
[cargo-make] ERROR - Error while running duckscript: Source: Unknown Line: 5 - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.
macalimlim commented 1 year ago

Hi @EverlastingBugstopper

May I know how did you install godot? is it on /Applications/Godot.app/Contents/MacOS/Godot?

macalimlim commented 1 year ago

@EverlastingBugstopper any update regarding my last query?