search

macarooni-man / auto-mcs

Cross-platform Minecraft server manager
https://www.auto-mcs.com
GNU General Public License v3.0
122 stars 6 forks source link

Docker Support #21

Open yesBad opened 8 months ago

yesBad commented 8 months ago

Hi there! Looks like a wonderful new software. I saw you already had some thoughts about this, just decided it could be added here as an issue.

I also wonder, how have you thought about this exactly? As currently one could make a simple image with NoVNC and make the app accessable via WebUI. The firewall stuff wouldn't work, but otherwise it would probably work.

I will personally take a look at spinning some dockerization with NoVNC. And leave some stuff about it here for those interested.

macarooni-man commented 8 months ago

Hi there! Looks like a wonderful new software. I saw you already had some thoughts about this, just decided it could be added here as an issue.

I also wonder, how have you thought about this exactly? As currently one could make a simple image with NoVNC and make the app accessable via WebUI. The firewall stuff wouldn't work, but otherwise it would probably work.

I will personally take a look at spinning some dockerization with NoVNC. And leave some stuff about it here for those interested.

Hello! Thanks for posting an issue, I like your idea a lot! The main dilemma I've had with this is the accessibility of install, and the efficacy of a WebUI.

NoVNC was my solution as well, though I'm still pondering how to make a streamlined setup for the end user to decide whether they want that feature or not. Some people wouldn't want the added complexity of a Docker installation along with an exposed WebUI.

yesBad commented 8 months ago

I have made a working NoVNC powered docker build of auto-mcs, source for the Dockerfile & extras are available at: https://github.com/yesBad/auto-mcs/tree/docker

If you would like to test it out, please feel free to do so as I have published a ghcr.io image: ghcr.io/yesbad/auto-mcs:novnc docker-compose is like so; https://github.com/yesBad/auto-mcs/blob/docker/docker-compose.yml

This dockerization I've done requires you to have "non root" Docker install, which is basically the basic stuff nowdays gladly.

Screenshot_20231230_151324

If your auto-mcs never starts, stop the container, then run chown -R 1000:1000 data as a root user.

(data folder by default as set in docker compose)

Please do not expose the NoVNC to public, it is in no way secure.. Keep it local & only for you! This is only for testing & development, it is very uh shitty implementation, but it works! :D

devsoleo commented 8 months ago

Works great ! Doing the chown command seems to be necessary for this to work ! image

yesBad commented 8 months ago

Yeah setting the UID & GID to 1000 is necessary.

pinkyplant commented 8 months ago

In Linuxserver.io docker images, there is options to set this. See below. `--- version: "2.1" services: qbittorrent: image: lscr.io/linuxserver/qbittorrent:latest container_name: qbittorrent environment:

pinkyplant commented 8 months ago

See This

yesBad commented 8 months ago

In Linuxserver.io docker images, there is options to set this. See below. --- version: "2.1" services: qbittorrent: image: lscr.io/linuxserver/qbittorrent:latest container_name: qbittorrent environment: - PUID=1000 - PGID=1000 - TZ=Etc/UTC - WEBUI_PORT=8080 volumes: - /path/to/appdata/config:/config - /path/to/downloads:/downloads ports: - 8080:8080 - 6881:6881 - 6881:6881/udp restart: unless-stopped Maybe we add this way? I am currently researching how this is done

Eh kind of useless, but I guess it could be nice QOL.

pinkyplant commented 8 months ago

Makes everyone’s life’s easier so it’s better.

On Wed, 3 Jan 2024 at 18:11, Bad @.***> wrote:

In Linuxserver.io docker images, there is options to set this. See below. --- version: "2.1" services: qbittorrent: image: lscr.io/linuxserver/qbittorrent:latest container_name: qbittorrent environment: - PUID=1000 - PGID=1000 - TZ=Etc/UTC - WEBUI_PORT=8080 volumes: - /path/to/appdata/config:/config - /path/to/downloads:/downloads ports: - 8080:8080 - 6881:6881 - 6881:6881/udp restart: unless-stopped Maybe we add this way? I am currently researching how this is done

Eh kind of useless, but I guess it could be nice QOL.

— Reply to this email directly, view it on GitHub https://github.com/macarooni-man/auto-mcs/issues/21#issuecomment-1875770735, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3LR5WZTXAEFQ3L4MAHPIUDYMWNNHAVCNFSM6AAAAABBHAZACWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVG43TANZTGU . You are receiving this because you commented.Message ID: @.***>

tarosbubbletea commented 6 months ago

I have made a working NoVNC powered docker build of auto-mcs...

By the way there's no file picker package installed in the container, so the "importing external servers" feature is broken image

yesBad commented 6 months ago

Yeah I'm aware a couple features are borked. (i.e all that open the file manager or ask for file etc)

macarooni-man commented 6 months ago

I have made a working NoVNC powered docker build of auto-mcs...

By the way there's no file picker package installed in the container, so the "importing external servers" feature is broken

@tarosbubbletea do you by chance have any suggestions on how to get a file picker to be passed through to the host?

yesBad commented 6 months ago

I'll be releasing WIP file support and the env UID/GID next week

EDIT; I've been 'optimizing' the "working parts" of the software and haven't done any new stuff yet.... this week tho right :)?

pinkyplant commented 1 week ago

Any updates on this? And would it maybe be possible to move the forked repository to a branch here for making it easier to find and QoL?