Closed macbookandrew closed 9 months ago
@hosungs would you mind trying out v1.10.0 before I publish it? I added some capability checking so only logged-in administrators can see the debug output, rather than everybody.
Honored to try out v1.10.0 before it's published! I don't know how to install an unpublished plugin, so I just updated the wp-youtube-live.php
file on my server with the modified one. It's great to see that the error message shows up when I logged on as an admin user, but doesn't when I logged on as a non-admin or not logged on at all! So it looks good to me. Thanks for making a release!
I wanted to leave some unrelated comments in the PR, but I'm surprised to find out that on Github one can't leave a comment on an unmodified line that's distant from any changed lines... :( So here goes my other comments:
Thanks again!
@hosungs great ideas! I set the backend to display the capability rather than the role name, as anybody using the plugin could use the wp_youtube_live_debug_user_capability
filter to modify it (e.g., to instead use a capability the editors have).
More info here if you’re curious: https://wordpress.org/documentation/article/roles-and-capabilities/
show_related
parameter