search

macbre / docker-nginx-http3

Stable and up-to-date root-less nginx with quic + http/3, google brotli compression, njs, GeoIP2, and Grade A+ SSL config
https://hub.docker.com/r/macbre/nginx-http3
159 stars 52 forks source link

Change expose line to normal ports please #108

Closed markg85 closed 3 weeks ago

markg85 commented 1 year ago

Hi,

The current dockerfile has: EXPOSE 8080 8443

This makes it super annoying to get the image working properly. Please just change it to a normal port 80 and 443.

I just spend a couple hours debugging this because i kept getting connection refused while my ports were set properly. Didn't try it but i probably should have used your "8080" and "8443" in the conf files as well to make it all work.

Just change it, please.

Cheers, Mark

macbre commented 1 year ago

Didn't try it but i probably should have used your "8080" and "8443" in the conf files as well to make it all work.

The EXPOSE statement in the Dockerfile just gives a hint about the exposed ports. It does not enforce anything. Ports above 1024 are used in this image to be able to run the nginx process as a non-root process. I'll try to make that clear in the README file.