Some kinds of DOMqueries are ignored

[gmetais]

Hi @macbre!

Phantomas is tracking:

• querySelectorAll but not querySelector
• Document.prototype.getElementsByClassName but not Element.prototype.getElementsByClassName
• Document.prototype.getElementsByTagName but not Element.prototype.getElementsByTagName

I believe they should be counted just like the others, don't you?

[macbre]

:+1:

[gmetais]

Hi @macbre!

Thanks a lot for fixing this issue so quickly. I was pretty happy with it but sorry, i just realized this changes were introducing another problem about the duplicated DOM queries.

For example:

element1.getElementsByClassName('foo')
element2.getElementsByClassName('foo')

These two queries are not the same and shouldn't be counted as duplicated. The context should be discriminent when counting duplicated queries with:

• Element.prototype.getElementsByClassName
• Element.prototype.getElementsByTagName
• Element.prototype.querySelector
• Element.prototype.querySelectorAll

What do you think about it?