maccesch / cmsplugin-contact

Extendable contact plugin for django-cms with spam protection and i18n
BSD 2-Clause "Simplified" License
71 stars 62 forks source link

django-cms 3.0 compatibility #46

Closed yohanboniface closed 11 years ago

yohanboniface commented 11 years ago

I've needed this to use the plugin with dj-cms trunk.

So here are the changes in case you want to merge them (they are supposed not to break the compatibility with the 2.x ;) ):

Thanks!

Yohan

mitar commented 11 years ago

Can you please make a pull request only with changes needed for the features you want. If you want to change code style, please make this another pull request.

yohanboniface commented 11 years ago

You have two commits, here:

Unless if you think that pep8 hasn't to be followed, I'm fine with this PR. :)

mitar commented 11 years ago

I know that there are two commits. And I am saying that this should be separate pull requests.

maccesch commented 11 years ago

I agree. Thanks! @mitar Come on, don't be like that. Code cleanup is always a good thing!

mitar commented 11 years ago

Eh eh. :-)

yohanboniface commented 11 years ago

Thanks :)