search

maccesch / cmsplugin-contact

Extendable contact plugin for django-cms with spam protection and i18n
BSD 2-Clause "Simplified" License
71 stars 62 forks source link

Made redirect funcionality, and solved multiples forms in the same page #65

Closed luisza closed 10 years ago

maccesch commented 10 years ago

Thanks a lot, this is great!

mitar commented 10 years ago

This is discussed in #29. It can probably be closed now?

Maybe we should use https://github.com/jonasgeiregat/django-excepted instead of custom middleware?

maccesch commented 10 years ago

Yes you're right we can close the discussion.

Actually since this middleware is just these few lines of code I think it doesn't warrant an extra dependency. Or do you think that there is an advantage?

mitar commented 10 years ago

Just thinking if one wants to use a similar patter in other use cases. Having multiple middlewares handling the same thing could be conflicting, or at least redundant. But just an idea.

luisza commented 10 years ago

The problem with django-excepted is that use process_exception and I used process_response because django cms raise exception in template and don't call process_exception (It's call in views)

ref: https://docs.djangoproject.com/en/dev/topics/http/middleware/#hooks-and-application-order

El 18/08/2014 15:31, Mitar escribió:

Just thinking if one wants to use a similar patter in other use cases. Having multiple middlewares handling the same thing could be conflicting, or at least redundant. But just an idea.

— Reply to this email directly or view it on GitHub https://github.com/maccesch/cmsplugin-contact/pull/65#issuecomment-52558272.

mitar commented 10 years ago

Aha. I understand.