search

maccesch / cmsplugin-contact

Extendable contact plugin for django-cms with spam protection and i18n
BSD 2-Clause "Simplified" License
71 stars 62 forks source link

Conctact form name (my_name) is required #66

Closed JackLeo closed 9 years ago

JackLeo commented 10 years ago

Hi, I am using your plugin and noticed that after an update it stopped working for me. I've looked at the form and noticed that it passes that some field is missing. After inspection I found that form is not valid because of id_my_name field.

Quick search gave this https://github.com/maccesch/cmsplugin-contact/blob/34f22f177fc79501d862f458d21ba9026046db9e/cmsplugin_contact/cms_plugins.py#L121

Contact form name is required, while in editing form in cms it's marked as not required. Not sure about your plans, but it would be great if ether form would require this field since without it does not send emails due to invalid form or you would changed that to handle empty form name.

JackLeo commented 10 years ago

By the way I am running this on 3.0.4, it maybe also because of that, but other than that it works fine for me on 3.x

maccesch commented 10 years ago

Thank you for the research. Would you mind fixing this and doing a quick pull request?

maccesch commented 9 years ago

New version on PIPy fixes this