search

maccesch / cmsplugin-contact

Extendable contact plugin for django-cms with spam protection and i18n
BSD 2-Clause "Simplified" License
71 stars 62 forks source link

added migration #86

Closed daanzap closed 8 years ago

daanzap commented 8 years ago

This migration is missing and creates a problem with deployment

maccesch commented 8 years ago

thanks man!

daanzap commented 8 years ago

No problem! Thanks for merging.

On Wed, Aug 10, 2016 at 3:04 PM, Marc-Stefan Cassola < notifications@github.com> wrote:

Merged #86 https://github.com/maccesch/cmsplugin-contact/pull/86.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maccesch/cmsplugin-contact/pull/86#event-751282114, or mute the thread https://github.com/notifications/unsubscribe-auth/AKvuxoK2WUaTQiFUGdO8xWQxRUOSco-3ks5qecxvgaJpZM4JhEh- .

daanzap commented 8 years ago

I just saw that in choices in form_layout now contains the form from our settings.

On Wed, Aug 10, 2016 at 3:05 PM, daniel versteegh daanzap@gmail.com wrote:

No problem! Thanks for merging.

On Wed, Aug 10, 2016 at 3:04 PM, Marc-Stefan Cassola < notifications@github.com> wrote:

Merged #86 https://github.com/maccesch/cmsplugin-contact/pull/86.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maccesch/cmsplugin-contact/pull/86#event-751282114, or mute the thread https://github.com/notifications/unsubscribe-auth/AKvuxoK2WUaTQiFUGdO8xWQxRUOSco-3ks5qecxvgaJpZM4JhEh- .

maccesch commented 8 years ago

Sorry, I don't understand what you mean

daanzap commented 8 years ago

https://github.com/maccesch/cmsplugin-contact/blob/master/cmsplugin_contact/migrations_django/0002_auto_20160810_1130.py#L17

this automatically copies the value from the settings.py so now it is set to our custom template.

this is the line causing the trouble:

choices=settings.CMSPLUGIN_CONTACT_FORMS

on the line: https://github.com/maccesch/cmsplugin-contact/blob/master/cmsplugin_contact/models.py#L31 I'll check if it's possible to dynamicly add choices without triggering a migration

Grt, Daan

On Wed, Aug 10, 2016 at 3:34 PM, Marc-Stefan Cassola < notifications@github.com> wrote:

Sorry, I don't understand what you mean

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maccesch/cmsplugin-contact/pull/86#issuecomment-238867694, or mute the thread https://github.com/notifications/unsubscribe-auth/AKvuxhlezY8iBaFPR8JTYwEkNhx4tS93ks5qedNJgaJpZM4JhEh- .