search

macchiato-framework / macchiato-core

Ring style HTTP server abstraction for Node.js
MIT License
377 stars 35 forks source link

Add optional transit configuration #31

Closed usernolan closed 6 years ago

usernolan commented 6 years ago

Wanted to get feedback before adding additional tests, renaming restul_format.cljs -> restful_format.cljs, aligning the formatting, etc.

yogthos commented 6 years ago

That looks great to me. I'm happy with the formatting, I tend to align things vertically as well. Good catch on the typo in the namespace name. :)

usernolan commented 6 years ago

Right on, appreciate the feedback. Will check through and add some more meaningful tests later in the week.

yogthos commented 6 years ago

and I'm happy to merge and push out an update if things look good to you

usernolan commented 6 years ago

Yeah if it checks out with you, it looks good to me! It's a simple change after all. I'll open up a new PR if I stumble into any premium improvements as I work with it more 👍.

Thanks again for all your work on this epic tool.

yogthos commented 6 years ago

And new version is up on Clojars, thanks again for a great PR. :)