search

macchiato-framework / macchiato-fs

ClojureScript wrapper for Node filesystem API
MIT License
21 stars 5 forks source link

Slurp now throws for non existing files instead of returning `nil` #15

Closed nenadalm closed 5 years ago

nenadalm commented 5 years ago

Fixes: https://github.com/macchiato-framework/macchiato-core/issues/38

I didn't update async test as it doesn't work anyway - it's async and should use async: https://cljs.github.io/api/cljs.test/#async. I've tried but then I've got this nothing telling error:

FAIL in (slurp-async-test) (at FSReqWrap.oncomplete (fs.js:141:20)
expected: false
  actual: false

also in the async test - first argument of callback is value, but it should be error :). Maybe doo is hiding some exception that occured...

You probably noticed, but ci is complaining on master about present package.json.

yogthos commented 5 years ago

Perfect thanks, and I'll take a look at updating the async test.

yogthos commented 5 years ago

Ok got the tests fixed, and just pushed out 0.2.2 with the fixes to Clojars.

nenadalm commented 5 years ago

thanks.