search

macchiato-framework / macchiato-template

a template for generating Macchiato-based apps
MIT License
60 stars 9 forks source link

os module used only at master #2

Closed spirinvladimir closed 7 years ago

spirinvladimir commented 7 years ago

Thanks for macchiato. It's super good. Macchiato inspire's me to use nodejs as backend platform.

My PR is about memory. I respect the rule about put js/require in one place. But it seem for me that it is more important to keep base workers light as much as possible.

Let's define os module at master process. Let's NOT define os module at every worker process.

yogthos commented 7 years ago

Thanks, that's a good catch and completely agree with the rationale.