macchina-io / macchina.io

macchina.io EDGE is a powerful C++ and JavaScript SDK for edge devices, multi-service IoT gateways and connected embedded systems.
https://macchina.io
GNU General Public License v3.0
512 stars 152 forks source link

unhide system env (DY)LD_LIBRARY_PATH #64

Closed bas524 closed 6 years ago

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


bas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

aleks-f commented 6 years ago

This pull is now coming from two users, of which one (Alexander B) does not seem to be a github user. Also, please split these contributions into cohesive separate pulls, adding update to 1.7.9p2 to a pull titled "unhide system env ..." is kindof messy (plus there are conflicts). Last but not least, in order for contributions to be accepted, all contributors must sign CLA

bas524 commented 6 years ago

sorry, both users are mine.. It's different options on different machines. (I understand about different pulls)

aleks-f commented 6 years ago

(I understand about different pulls)

I suggest to close this pull and create two new separate pulls.

I'm also, not sure about the poco upgrade here, @obiltschnig will have to approve that (poco 1.8.0.1 is already released)

bas524 commented 6 years ago

Ok, I agree. Can you close this pull request?