search

maccman / abba

A/B testing framework
MIT License
1.35k stars 70 forks source link

Changed the registration of js functions #12

Closed SeriousM closed 11 years ago

SeriousM commented 11 years ago

Hi,

I noticed you are using => instead of -> in the client/index.coffee file. The problem is that this pollutes the window namespace.

I replaced all => with -> to avoid that. Everything works fine with this change.

maccman commented 11 years ago

I'm not sure that's accurate. Aren't they on the Abba class?

SeriousM commented 11 years ago

They were on the Abba class but also registered on the current scope which is the window itself. Please verify it yourself by checking the compiled js code from your version and mine.

maccman commented 11 years ago

I stand corrected!

SeriousM commented 11 years ago

btw, I think you will have the same problem with the other coffee scripts but that is not that serious because it is used only by the abba site itself.

Cheers & Thanks for that great project!