search

maccmu / macposts

MIT License
11 stars 3 forks source link

NetworkX requires Python>3.8 #27

Open ghost opened 1 year ago

ghost commented 1 year ago

NetworkX no longer supports Python 3.7 and 3.8 (https://github.com/networkx/networkx/pull/6733), which we are supporting now. As such, we are seeing a failure in our testing (https://github.com/maccmu/macposts/actions/runs/5329931956/jobs/9679446744).

I am planning to drop support for Python 3.7 soon because its EOL is on 2023-06-27. However, I am not sure if we should drop support for Python 3.8 so early because NetworkX is only required in 'examples/mcdta-7link.ipynb'.

psychogeekir commented 1 year ago

Agree to drop support for Python 3.7. Probably add some warning to users about this issue in that Jupyter notebook?

ghost commented 1 year ago

Alternatively we may switch to igraph.

Actually I was thinking to replace SNAP with igraph for the internal graph data structures as well. So igraph may eventually become a runtime dependency.

psychogeekir commented 1 year ago

This works.

To my understanding, it seems for now macposts doesn't rely very much on any other advanced functionalities of these external graph packages except using the data structure to store and access the graph. Maybe I am being naive about this, if this is the only dependency, can we just write an graph class on our own in order to get rid of SNAP? Introducing a whole external package seems too much work?

But if the performance is the issue or we may need to use other functionalities of these existing graph packages, probably we need to integrate igraph with macposts.

Qiling Zou

From: kunhtkun @.> Sent: Wednesday, June 21, 2023 11:41:17 PM To: maccmu/macposts @.> Cc: psychogeekir @.>; Comment @.> Subject: Re: [maccmu/macposts] NetworkX requires Python > 3.8 (Issue #27)

Alternatively we may switch to igraphhttps://github.com/igraph/python-igraph.

Actually I was thinking to replace SNAP with igraph for the internal graph data structures as well. So igraph may eventually become a runtime dependency.

— Reply to this email directly, view it on GitHubhttps://github.com/maccmu/macposts/issues/27#issuecomment-1601969669, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXEA7OFRVB7GPMH4SGYUZTXMO5F3ANCNFSM6AAAAAAZPOXWXE. You are receiving this because you commented.Message ID: @.***>

ghost commented 1 year ago

I am also considering this, but let us keep this issue on topic and move the discussion on how to store the network to a new issue.